Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get token using jwt / private key #19

Open
drzraf opened this issue Mar 9, 2020 · 4 comments
Open

Get token using jwt / private key #19

drzraf opened this issue Mar 9, 2020 · 4 comments

Comments

@drzraf
Copy link
Contributor

drzraf commented Mar 9, 2020

If a token expired, two ways to get a fresh one are provided. Either using getPasswordAccessToken either by getClientCredentialsAccessToken which relies upon client client's id and secret:

private function getClientCredentialsAccessToken(): OAuthAccessToken

I think it's missing the 3rd one, using a private key. Would you accept a MR which would basically add a (?string) $privateKey parameter on the model of $clientId & co and a getJwtAccessToken($client_id, $private_key, $validity = 3600) method?

Please note that OAuthRestClient is final.

@drzraf drzraf changed the title Token per jwt Get token using jwt / private key Mar 9, 2020
@jasonraimondi
Copy link
Contributor

I'm not sure I have access to this project anymore, but if you submit PR's, I'd look over them, and as long as there are no backwards breaking changes, I'd imagine we could see about merging it. Worst case, feel free to fork the repo and make your changes there.

@drzraf
Copy link
Contributor Author

drzraf commented Oct 24, 2022

@toddcornett then?

@drzraf
Copy link
Contributor Author

drzraf commented Oct 31, 2023

ping :)

@jasonraimondi
Copy link
Contributor

ping :)

No offense man, but it is 4 years from your original post and you still haven't made a PR for this. Either make a PR and hope it gets merged, or fork the project and go that route.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants