-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get token using jwt / private key #19
Comments
I'm not sure I have access to this project anymore, but if you submit PR's, I'd look over them, and as long as there are no backwards breaking changes, I'd imagine we could see about merging it. Worst case, feel free to fork the repo and make your changes there. |
@toddcornett then? |
ping :) |
No offense man, but it is 4 years from your original post and you still haven't made a PR for this. Either make a PR and hope it gets merged, or fork the project and go that route. |
If a token expired, two ways to get a fresh one are provided. Either using
getPasswordAccessToken
either bygetClientCredentialsAccessToken
which relies upon client client'sid
andsecret
:restforcephp/src/Rest/OAuthRestClient.php
Line 142 in 0f3589b
I think it's missing the 3rd one, using a private key. Would you accept a MR which would basically add a
(?string)
$privateKey
parameter on the model of$clientId
& co and agetJwtAccessToken($client_id, $private_key, $validity = 3600)
method?Please note that
OAuthRestClient
is final.The text was updated successfully, but these errors were encountered: