Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Installation page is broken in eunomia-bpf #26

Open
Viveksati5143 opened this issue Feb 28, 2024 · 9 comments
Open

[BUG] Installation page is broken in eunomia-bpf #26

Viveksati5143 opened this issue Feb 28, 2024 · 9 comments
Labels
bug Something isn't working

Comments

@Viveksati5143
Copy link

Viveksati5143 commented Feb 28, 2024

Describe the bug

The below link is broken.
https://eunomia.dev/eunomia-bpf/setup/

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'eunomia.dev website'
  2. Click on 'eunomia-bpf'
  3. Scroll down to 'setup'
  4. See error

Expected behavior

It should lead setup page in the repo

Screenshots

image image

Desktop (please complete the following information):

  • OS: [e.g. Windows]
  • Version [e.g. 10]

Additional context

I would like to fix this issue

@Viveksati5143 Viveksati5143 added the bug Something isn't working label Feb 28, 2024
@Viveksati5143 Viveksati5143 changed the title [BUG] Installation page is broken [BUG] Installation page is broken in eunomia-bpf Feb 28, 2024
@Viveksati5143
Copy link
Author

@yunwei37 can you provide me the accurate link to fix this?

@yunwei37
Copy link
Member

I'm finding it...

@Viveksati5143
Copy link
Author

I'm finding it...

okay.. will wait...

@yunwei37
Copy link
Member

Seems like it's here: https://github.com/eunomia-bpf/eunomia-bpf/tree/master/documents/src

You can run make build to successfully download and build the website, the documents in other repo will be move into the correct position.

@yunwei37
Copy link
Member

Is it better to move all the documents for the tools to this repo?

It can simplify the build process and avoid misunderstanding. See https://github.com/eunomia-bpf/eunomia.dev/blob/main/rename.sh and the Makefile, currently we need to download the documents from other repo, rename it and build the website.

After refactor, the only thing outside this repo and need copy and build will be the tutorials and project README.md. They should be in other repo.

Related to eunomia-bpf/eunomia-bpf#340

@yunwei37
Copy link
Member

Thanks for your help!

@Viveksati5143
Copy link
Author

Will definitely raise a pr for this once #25 gets merged!!

@hp77-creator
Copy link
Contributor

hp77-creator commented Jun 30, 2024

After refactor, the only thing outside this repo and need copy and build will be the tutorials and project README.md. They should be in other repo.

Should 'readme' be also in other repo? I saw that wasm-bpf's index.md has content similar to Readme only other projects don't.

@yunwei37 @Officeyutong

@yunwei37
Copy link
Member

Yes, all project readme should be in other repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants