-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Field "chain" is used twice with different meaning/definition #2373
Comments
true - this is inconsistent |
migration path:
|
Excuse me? How would I index to the parent chain if the value of "parent.chain" is NOT on the parent?! |
the filename is CAIP2 and the values of chain fields in parent is CAIP2 |
They would need to be "eip155:1" instead of "eip155-1" for CAIP2. |
from the feedback have you like that we need to do the old behind and welcome new |
I would clarify what does "chain" mean, given that we have "parent.chain" that has a different definition.
Since the latter is dependent on / specific to this repository and doesn't have a correspondence on a on-chain value (EIPs are off-chain right?), I would consolidate to the former and make a clear definition of what is it.
There are irregularities currently on the "chain" field values, examples:
In general, I would add comments to
https://github.com/ethereum-lists/chains/blob/master/model/src/main/kotlin/org/ethereum/lists/chains/model/Chain.kt
to help listers provide consistent values.
The text was updated successfully, but these errors were encountered: