Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev-python/watchgod being removed from gentoo repositories #157

Open
CaseOf opened this issue Nov 12, 2022 · 7 comments
Open

dev-python/watchgod being removed from gentoo repositories #157

CaseOf opened this issue Nov 12, 2022 · 7 comments

Comments

@CaseOf
Copy link

CaseOf commented Nov 12, 2022

Hello,

I’ve noticed on update that now dev-python/watchgod is being masked. It will be removed on 2022-12⁻04.
They were saying it was only used by dev-python/uvicorn and that they have replaced it by dev-python/watchfiles.

What should I do for etebase server? Should I add watchgod on my own overlay? Should we work on etebase switching on it?

They have linked a bug report for this #879515.

Their original comment about the package mask:

# Michał Górny <[email protected]> (2022-11-04)
# NIH version of dev-python/watchdog that was used by dev-python/uvicorn
# only, and was replaced by rustified dev-python/watchfiles.
# Removal on 2022-12-04.  Bug #879515.
@Xiretza
Copy link
Contributor

Xiretza commented Nov 12, 2022

I don't think etebase-server depends on watchgod? It's only a transitive dependency through uvicorn, so if that gets moved to another package it shouldn't affect etebase-server.

@CaseOf
Copy link
Author

CaseOf commented Nov 12, 2022

Ok, I’m removing this dependency.

@CaseOf
Copy link
Author

CaseOf commented Nov 12, 2022

Just to be sure, these are actually the dependencies I’ve set for etebase. Is there something to change?

                >=dev-python/aiofiles-0.8.0[${PYTHON_USEDEP}]
                >=dev-python/django-3.2.12[${PYTHON_USEDEP},sqlite]
                <dev-python/django-4.0.0[${PYTHON_USEDEP},sqlite]
                >=dev-python/fastapi-0.75.0[${PYTHON_USEDEP}]
                >=dev-python/httptools-0.4.0[${PYTHON_USEDEP}]
                >=dev-python/msgpack-1.0.3[${PYTHON_USEDEP}]
                >=dev-python/pynacl-1.5.0[${PYTHON_USEDEP}]
                >=dev-python/python-dotenv-0.19.2[${PYTHON_USEDEP}]
                >=dev-python/pytz-2022.1[${PYTHON_USEDEP}]
                >=dev-python/pyyaml-6.0[${PYTHON_USEDEP}]
                >=dev-python/redis-py-4.2.0[${PYTHON_USEDEP}]
                >=dev-python/uvicorn-0.17.6[${PYTHON_USEDEP}]
                >=dev-python/uvloop-0.16.0[${PYTHON_USEDEP}]
                >=dev-python/websockets-10.2[${PYTHON_USEDEP}]

@tasn
Copy link
Member

tasn commented Nov 13, 2022

These are the direct Etebase dependencies: https://github.com/etesync/server/blob/master/requirements.in/base.txt

@CaseOf
Copy link
Author

CaseOf commented Nov 13, 2022

Oops, I do not have typing_extensions. Also saw some deps that I could clean.

@CaseOf
Copy link
Author

CaseOf commented Nov 13, 2022

About direct dependencies, it seems that on Gentoo, the dependency tree is not exactly the same than on python projects.
Then some dependencies may be missing after that.
That explains why I was watching the complete dependency tree. But if you are not actively using them on etebase, I should remove them.

@tasn
Copy link
Member

tasn commented Nov 13, 2022

Yeah, not using watchgod, it's only useful for dev.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants