Lib.fold crashes in the script editor #378
Labels
Comments
This was referenced Jun 9, 2024
luxaritas
pushed a commit
to eternagame/EternaJS
that referenced
this issue
Dec 20, 2024
## Summary This is part of the process of extracting the script-facing API from PoseEditMode in order to make it usable for non-booster scripts. Replaces #749 ## Implementation Notes I did it like the previous PR, except I didn't implement get_folder/select_folder, since they are behind a "lock", and I didn't want to think yet of whether or not I want the extracted logic to inherit the lock. However, while get_folder is locked, the calculation functions (such as `fold`) which also access the folder, aren't locked (even on `dev`). Is this intended? ## Testing I ran https://eternagame.org/scripts/13774466, and it passed. The script checks that all of the extracted functions (expect folding with binding sites) work and return the same values. This is an unrelated issue, but : For some reason, both on main/master (https://eternagame.org/puzzles/6096060/play) and on my branch, the first time I run it I get the following errors, and on future runs it passes. Reloading the page makes the issue appear again for a single execution. Errors:  Successful run:  (In my branch I just copy pasted the script, since I didn't have it on eternadev.org, and changed `Lib.fold`->`applet.fold`. I shouldn't have Lib in the terminal, right?) ## Related Issues Enables eternagame/eternagame.org#378, #750
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Expected Behavior
Woah there are different sections build in here... cool
Lib.foldshould work both in the script editor, and in boosters, like how it did in the old site.Alternatively, it should be documented to not work, and raise an indicative error, such as "Scripts trying to fold sequences don't work anymore" (so that old etc. scripts which were based on
Lib.foldwould get a clear deprecation error)Current Behavior
I get the following result in firefox:
And in chrome:
and no errors in the console
Reproduction Steps
Run https://eternagame.org/scripts/13522515
Environment
Firefox 126.0.1 (64-bit)
Chrome 125.0.6422.142 (Official Build) (64-bit) (cohort: Stable)
Windows 11 Version 23H2 (Build 22631.3672)
Other information
No response
The text was updated successfully, but these errors were encountered: