adding tagstack support

[tksoh]

Original nedit has a patch for adding vim-like tagstack feature on Sourceforge:

https://sourceforge.net/p/nedit/patches/60/

A version implemented with nedit macro is also available. Perhaps something to consider for adding into nedit-ng.

[tksoh]

Here's VIM's doc on the feature for reference:

https://vim.fandom.com/wiki/Browsing_programs_with_tags

[eteran]

Thanks!, I'll take a look. There definitely is an argument to be made for creating a healthy "macro ecosystem" for nedit-ng by implementing things that could be macros as macros. Though, we may want to figure out some sort of "macro repository" if we really want to go that route.

For this one, I'll have to play with the idea and see what "feels right". I can say that the fact that we already have a tag search feature and this would basically be kinda adding a history to that makes me lean built-in, but you make a good enough point that I'm not 100% sure which way I'll go with this one.

Either way, this seems like a cool feature, so one way or another, we'll get it in there :-).

[tksoh]

If you view NG as a new version of nedit, then obviously all features supported by nedit 5 need to be present or at least backwards compatible, even though they might not be meaningful due to the new toolkit/environment. This is particularly critical for the macro users.

[tksoh]

BTW, the tabbed editing feature was added on top of existing nedit architecture (raise_window and focus-pane were already there before that), and it was intentionally made to allow to the macros to run as-is. The document vs windows distinction is a matter of GUI appearance. Macro does not see the difference in most, if not all, situation.

[tksoh]

I will try out the new change if I get the opportunity.

[tksoh]

I tried your PR. Popping the stack appears to be working, but without raise_window support, it will naturally only work within the same document.

[eteran]

@tksoh OK, bookmark fix tested and now merged :-)

If you view NG as a new version of nedit, then obviously all features supported by nedit 5 need to be present or at least backwards compatible, even though they might not be meaningful due to the new toolkit/environment. This is particularly critical for the macro users.

I do of course view NG as the new version of nedit :-). So I agree, that NG needs to be as backward compatible as possible.

Though, there is of course subtlety to this. For example, some things that are technically available to macros aren't even documented, so it's hard to tell if they were even intended to be usable, or if they are usable simply due to implementation details happening to make it work.

For example, technically, a macro in nedit-classic can call toggle_overstrike... but I'm unsure if this is omited from the docs because someone forgot to update the docs, or because no one even knew it was technically callable :-P.

None the less, the number of macro functions currently left unimplemented is pretty small. The bottom line is that I agree with you, and will implement all of the ones that can sanely be implemented, even if that implementation is simply returning success and printing a debug message saying that usage is deprecated.

[eteran]

tagstack-v1_0.menu.txt
tagstack-v1.3-nedit-5.7.patch.txt

Just adding a quick copy of both the patch and macro file here too for quick reference :-)