-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Invalid value in i2c device configuration for CST816 touch driver (BSP-623) #485
Comments
@0xPIT Thank you for the report! This must have slipped in during our code reviews, will fix |
After modification, in the file : "components/esp_lcd/i2c/esp_lcd_panel_io_i2c_v1.c" , Line 60 an error occurred. ESP_GOTO_ON_FALSE(io_config->scl_speed_hz == 0, ESP_ERR_INVALID_ARG, err, TAG, "scl_speed_hz is not need to set in legacy i2c_lcd driver"); Simply making changes has poor compatibility. |
@jpw168 Please se it to 0, in case you still use the legacy I2C driver |
The configuration in the header file for the CST816 driver causes a runtime assertion when used with
i2c_master_bus_add_device()
:E (715) i2c.master: i2c_master_bus_add_device(990): invalid scl frequency
This is because
i2c_master_bus_add_device()
assertsscl_speed_hz > 0
.Please fix in this (and potentially other) drivers.
The text was updated successfully, but these errors were encountered: