Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation when uart console is disabled (GIT8266O-648) #1070

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pheki
Copy link

@pheki pheki commented Mar 25, 2021

As CONFIG_ESP_CONSOLE_UART_BAUDRATE is undefined when UART is set to CONFIG_ESP_CONSOLE_UART_NONE, the SDK was failing to compile with an error here.

This PR fixes it by not modifying baud rate when UART's disabled, as there's no need to.

Thanks!

@CLAassistant
Copy link

CLAassistant commented Mar 25, 2021

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions github-actions bot changed the title Fix compilation when uart console is disabled Fix compilation when uart console is disabled (GIT8266O-648) Mar 25, 2021
@mriksman
Copy link

I'm having the same issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants