Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add config to enable EC-JPAKE and HKDF (GIT8266O-634) #1056

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

add config to enable EC-JPAKE and HKDF (GIT8266O-634) #1056

wants to merge 2 commits into from

Conversation

Kxuan
Copy link

@Kxuan Kxuan commented Feb 23, 2021

We need EC-JPAKE and HKDF in our ESP8266 project. But the mbedtls in ESP8266 does not enable these two features.

In esp-idf, these two configs have already been added in Kconfig.

I picked the two patches from esp-idf, and hope they can be merged into ESP8266 v3.4.

@CLAassistant
Copy link

CLAassistant commented Feb 23, 2021

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
0 out of 2 committers have signed the CLA.

❌ shahpiyushv
❌ wgtdkp
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions github-actions bot changed the title add config to enable EC-JPAKE and HKDF add config to enable EC-JPAKE and HKDF (GIT8266O-634) Feb 23, 2021
@Kxuan
Copy link
Author

Kxuan commented Feb 23, 2021

@shahpiyushv @wgtdkp

Could you please check these patches? It really helpful if these two option are providered in ESP8266's Kconfig

Copy link

@wgtdkp wgtdkp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants