Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure ESP_PLATFORM is defined when processing CMake files. (GIT8266O-602) #1025

Closed
wants to merge 1 commit into from

Conversation

jkent
Copy link

@jkent jkent commented Dec 25, 2020

Corresponding ESP-IDF PR: espressif/esp-idf#3945

@CLAassistant
Copy link

CLAassistant commented Dec 25, 2020

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot changed the title Make sure ESP_PLATFORM is defined when processing CMake files. Make sure ESP_PLATFORM is defined when processing CMake files. (GIT8266O-602) Dec 25, 2020
@jkent
Copy link
Author

jkent commented Aug 7, 2024

It appears this may no longer be relevant in 2024. I shall test.

@jkent
Copy link
Author

jkent commented Aug 7, 2024

It indeed is not required. Closing.

@jkent jkent closed this Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants