Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include more unit/integration tests where possible #168

Closed
jessebraham opened this issue Apr 26, 2022 · 3 comments
Closed

Include more unit/integration tests where possible #168

jessebraham opened this issue Apr 26, 2022 · 3 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@jessebraham
Copy link
Member

jessebraham commented Apr 26, 2022

Certain modules can likely be tested quite thoroughly, so we should add more tests.

It would be nice to include more unit tests especially, though this may require refactoring. Some sort of end-to-end testing of the CLI subcommands would be interesting as well, though that is unexplored territory for me.

Resources:

@jessebraham jessebraham added help wanted Extra attention is needed good first issue Good for newcomers labels Apr 26, 2022
@jessebraham jessebraham added this to the v2 milestone Oct 5, 2022
@jessebraham jessebraham changed the title Include more unit tests where possible Include more unit/integration tests where possible Oct 12, 2022
@jessebraham jessebraham moved this to Todo in esp-rs Oct 17, 2022
@jessebraham jessebraham self-assigned this Oct 19, 2022
@jessebraham
Copy link
Member Author

  • Since being split out, esp-idf-part now has quite reasonable test coverage; in turn, our partition table handling does as well.
  • The image format tests have been updated for the IdfBootloader and Esp8266 image formats; there is still no test for the DirectBoot format.

@jessebraham
Copy link
Member Author

I'm going to call this "good enough" for the 2.0.x release, though I'll leave the issue open as we should still investigate improving the current situation.

@jessebraham jessebraham removed this from the v2 milestone Oct 24, 2022
@jessebraham jessebraham removed their assignment Oct 25, 2022
@jessebraham
Copy link
Member Author

I'm not sure there's much more testing we can do without some major refactoring, and we have #439 open for some HIL-like testing, so gonna go ahead and close this.

@github-project-automation github-project-automation bot moved this from Todo to Done in esp-rs Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
Archived in project
Development

No branches or pull requests

1 participant