Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Probably the unmarkedText() method was accidentally disabled #898

Open
raspopov opened this issue Jan 11, 2025 · 0 comments
Open

Probably the unmarkedText() method was accidentally disabled #898

raspopov opened this issue Jan 11, 2025 · 0 comments

Comments

@raspopov
Copy link

raspopov commented Jan 11, 2025

The MantisBT project has been using awesome Parsedown 1.7.4 for a long time and now we are trying to upgrade to latest version i.e. 1.8, but unexpectedly we found a regression in the tests.

Further investigation revealed that the commit eb55e42 (1.7.1 -> 1.8) removed the use of the unmarkedText() method, although the method itself remains and is not used anywhere else.

The problem is that MantisBT uses this overloaded method to extend syntax to mark up an email without angle brackets.

If it is possible to get some insight into whether this is a bug that needs to be fixed or just leftover unnecessary code (which, if true, would break the class interface), that would be greatly appreciated. This would help us plan the development of MantisBT.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant