Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should collide-with be deprecated in favour of collide-with! #15

Open
simon-brooke opened this issue May 25, 2024 · 2 comments
Open

Should collide-with be deprecated in favour of collide-with! #15

simon-brooke opened this issue May 25, 2024 · 2 comments

Comments

@simon-brooke
Copy link
Contributor

The function collide-with modifies its third argument, an instance of CollisionResults, by potentially adding a new CollisionResult object. It's conventional in Clojure to mark functions which are not pure functions with an exclamation mark suffix.

I propose:

  1. create a new function collide-with! with the same code as the existing collide-with;
  2. alter collide-with to call collide-with!;
  3. deprecate collide-with in favour of collide-with!.

Let me know whether a pull request to this effect would be acceptable.

@ertugrulcetin
Copy link
Owner

Sure, if you create a PR, I'd happy to merge it

@ertugrulcetin
Copy link
Owner

@simon-brooke I sent you an access permission to this repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants