Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does the language server support spelling rules #15

Closed
ChrisChinchilla opened this issue Jul 12, 2024 · 4 comments
Closed

Does the language server support spelling rules #15

ChrisChinchilla opened this issue Jul 12, 2024 · 4 comments
Labels
question Further information is requested

Comments

@ChrisChinchilla
Copy link

Kind of referencing this too : errata-ai/LSP-vale-ls#3

I now have all rules working with quickfix in VSCode extension, but spelling rules don't return a quick fix? Should the language server do that? And if so, what dictionary is it using by default?

@jdkato
Copy link
Member

jdkato commented Jul 16, 2024

Yes, it does. The dictionary is determined by the rule -- if it specifies a custom one, then that is used. Otherwise, the default is used.

@ChrisChinchilla
Copy link
Author

Hmm, interesting, then I wonder why I can't get it to show anything 🤔 . Will investigate.

@ChrisChinchilla
Copy link
Author

I can't even get the spelling quick fix to register in the Sublime extension. I wonder, is there some configuration or rule error I should check for? I am using the same rules that work in the current VSCode extension, this rule: https://github.com/ChrisChinchilla/Openly/blob/main/Openly/Spelling.yml that's using an npm package dictionary.

I wonder if somehow I deleted a dictionary file or something, but I don't see any errors.

@ChrisChinchilla
Copy link
Author

I found that somehow I had modified a rule, and this now works.

@jdkato jdkato added the question Further information is requested label Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants