Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open Declaration (F3) confused by fun in arguments list #16

Open
fowlay opened this issue Dec 22, 2017 · 3 comments
Open

Open Declaration (F3) confused by fun in arguments list #16

fowlay opened this issue Dec 22, 2017 · 3 comments

Comments

@fowlay
Copy link

fowlay commented Dec 22, 2017

Two simple modules are attached: f3 and f3lib. Change the filenames to f3.erl and f3lib.erl, and add them to an Erlang project. View the f3 module in Eclipse with Erlide. Place the cursor after the colon in line 8. Press F3, or menu-click and do "Open Declaration". This should cause the f3lib:b/4 function to come into focus. However, it is the f3lib:b/3 function that gets the focus.

@fowlay
Copy link
Author

fowlay commented Dec 22, 2017

f3.txt
f3lib.txt

@vladdu
Copy link
Collaborator

vladdu commented Dec 22, 2017

Thanks for reporting that! My guess is that the first function in the file is used, instead of checking the arity. I am now working on a new implementation using the language server protocol, which I hope to be able to release soon (tm), so I'm not sure if it is worth fixing this in the current code. If you think I should, please let me know.

@fowlay
Copy link
Author

fowlay commented Dec 28, 2017

Hi Vlad, I think the coding style with "literal" funs in the argument list of a function call occurs very infrequently in real life. So put your efforts with the new implementation instead, it will be exciting to try out later on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants