diff --git a/internal/tools/monitor/core/storekit/clickhouse/table/meta/cache.go b/internal/tools/monitor/core/storekit/clickhouse/table/meta/cache.go index 3017f093975..a41782440d7 100644 --- a/internal/tools/monitor/core/storekit/clickhouse/table/meta/cache.go +++ b/internal/tools/monitor/core/storekit/clickhouse/table/meta/cache.go @@ -29,9 +29,7 @@ func (p *provider) setCache() error { expire := 3 * p.Cfg.ReloadInterval var caches []MetricMeta - for _, v := range meta { - caches = append(caches, v) - } + caches = append(caches, meta...) text, err := json.MarshalToString(caches) diff --git a/internal/tools/monitor/extensions/loghub/exporter/output_test.go b/internal/tools/monitor/extensions/loghub/exporter/output_test.go index 4ea61705922..2a768dd816a 100644 --- a/internal/tools/monitor/extensions/loghub/exporter/output_test.go +++ b/internal/tools/monitor/extensions/loghub/exporter/output_test.go @@ -360,9 +360,7 @@ func (m *MockLogger) EXPECT() *MockLoggerMockRecorder { func (m *MockLogger) Debug(arg0 ...interface{}) { m.ctrl.T.Helper() varargs := []interface{}{} - for _, a := range arg0 { - varargs = append(varargs, a) - } + varargs = append(varargs, arg0...) m.ctrl.Call(m, "Debug", varargs...) } @@ -376,9 +374,7 @@ func (mr *MockLoggerMockRecorder) Debug(arg0 ...interface{}) *gomock.Call { func (m *MockLogger) Debugf(arg0 string, arg1 ...interface{}) { m.ctrl.T.Helper() varargs := []interface{}{arg0} - for _, a := range arg1 { - varargs = append(varargs, a) - } + varargs = append(varargs, arg1...) m.ctrl.Call(m, "Debugf", varargs...) } @@ -393,9 +389,7 @@ func (mr *MockLoggerMockRecorder) Debugf(arg0 interface{}, arg1 ...interface{}) func (m *MockLogger) Error(arg0 ...interface{}) { m.ctrl.T.Helper() varargs := []interface{}{} - for _, a := range arg0 { - varargs = append(varargs, a) - } + varargs = append(varargs, arg0...) m.ctrl.Call(m, "Error", varargs...) } @@ -409,9 +403,7 @@ func (mr *MockLoggerMockRecorder) Error(arg0 ...interface{}) *gomock.Call { func (m *MockLogger) Errorf(arg0 string, arg1 ...interface{}) { m.ctrl.T.Helper() varargs := []interface{}{arg0} - for _, a := range arg1 { - varargs = append(varargs, a) - } + varargs = append(varargs, arg1...) m.ctrl.Call(m, "Errorf", varargs...) } @@ -426,9 +418,7 @@ func (mr *MockLoggerMockRecorder) Errorf(arg0 interface{}, arg1 ...interface{}) func (m *MockLogger) Fatal(arg0 ...interface{}) { m.ctrl.T.Helper() varargs := []interface{}{} - for _, a := range arg0 { - varargs = append(varargs, a) - } + varargs = append(varargs, arg0...) m.ctrl.Call(m, "Fatal", varargs...) } @@ -442,9 +432,7 @@ func (mr *MockLoggerMockRecorder) Fatal(arg0 ...interface{}) *gomock.Call { func (m *MockLogger) Fatalf(arg0 string, arg1 ...interface{}) { m.ctrl.T.Helper() varargs := []interface{}{arg0} - for _, a := range arg1 { - varargs = append(varargs, a) - } + varargs = append(varargs, arg1...) m.ctrl.Call(m, "Fatalf", varargs...) } @@ -459,9 +447,7 @@ func (mr *MockLoggerMockRecorder) Fatalf(arg0 interface{}, arg1 ...interface{}) func (m *MockLogger) Info(arg0 ...interface{}) { m.ctrl.T.Helper() varargs := []interface{}{} - for _, a := range arg0 { - varargs = append(varargs, a) - } + varargs = append(varargs, arg0...) m.ctrl.Call(m, "Info", varargs...) } @@ -475,9 +461,7 @@ func (mr *MockLoggerMockRecorder) Info(arg0 ...interface{}) *gomock.Call { func (m *MockLogger) Infof(arg0 string, arg1 ...interface{}) { m.ctrl.T.Helper() varargs := []interface{}{arg0} - for _, a := range arg1 { - varargs = append(varargs, a) - } + varargs = append(varargs, arg1...) m.ctrl.Call(m, "Infof", varargs...) } @@ -492,9 +476,7 @@ func (mr *MockLoggerMockRecorder) Infof(arg0 interface{}, arg1 ...interface{}) * func (m *MockLogger) Panic(arg0 ...interface{}) { m.ctrl.T.Helper() varargs := []interface{}{} - for _, a := range arg0 { - varargs = append(varargs, a) - } + varargs = append(varargs, arg0...) m.ctrl.Call(m, "Panic", varargs...) } @@ -508,9 +490,7 @@ func (mr *MockLoggerMockRecorder) Panic(arg0 ...interface{}) *gomock.Call { func (m *MockLogger) Panicf(arg0 string, arg1 ...interface{}) { m.ctrl.T.Helper() varargs := []interface{}{arg0} - for _, a := range arg1 { - varargs = append(varargs, a) - } + varargs = append(varargs, arg1...) m.ctrl.Call(m, "Panicf", varargs...) } @@ -553,9 +533,7 @@ func (mr *MockLoggerMockRecorder) Sub(arg0 interface{}) *gomock.Call { func (m *MockLogger) Warn(arg0 ...interface{}) { m.ctrl.T.Helper() varargs := []interface{}{} - for _, a := range arg0 { - varargs = append(varargs, a) - } + varargs = append(varargs, arg0...) m.ctrl.Call(m, "Warn", varargs...) } @@ -569,9 +547,7 @@ func (mr *MockLoggerMockRecorder) Warn(arg0 ...interface{}) *gomock.Call { func (m *MockLogger) Warnf(arg0 string, arg1 ...interface{}) { m.ctrl.T.Helper() varargs := []interface{}{arg0} - for _, a := range arg1 { - varargs = append(varargs, a) - } + varargs = append(varargs, arg1...) m.ctrl.Call(m, "Warnf", varargs...) } diff --git a/internal/tools/pipeline/pkg/taskerror/ordered.go b/internal/tools/pipeline/pkg/taskerror/ordered.go index 9b1ebfe58a3..d4fd3718de9 100644 --- a/internal/tools/pipeline/pkg/taskerror/ordered.go +++ b/internal/tools/pipeline/pkg/taskerror/ordered.go @@ -42,9 +42,7 @@ func (o OrderedErrors) AppendError(errs ...*Error) OrderedErrors { return o } var ordered OrderedErrors - for _, g := range o { - ordered = append(ordered, g) - } + ordered = append(ordered, o...) var newOrderedErrs OrderedErrors now := time.Now() diff --git a/pkg/strutil/strutil.go b/pkg/strutil/strutil.go index 44cbbac1a63..485c4d158de 100644 --- a/pkg/strutil/strutil.go +++ b/pkg/strutil/strutil.go @@ -393,9 +393,7 @@ func Atoi64(s string) (int64, error) { // Map([]string{"Aa", "bB", "cc"}, ToLower, Title) => []string{"Aa", "Bb", "Cc"} func Map(ss []string, fs ...func(s string) string) []string { r := []string{} - for i := range ss { - r = append(r, ss[i]) - } + r = append(r, ss...) r2 := []string{} for _, f := range fs { for i := range r {