Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Displaying PDB BU assignments #100

Closed
josemduarte opened this issue Apr 7, 2016 · 6 comments
Closed

Displaying PDB BU assignments #100

josemduarte opened this issue Apr 7, 2016 · 6 comments
Labels
Milestone

Comments

@josemduarte
Copy link
Contributor

We've got the matching between PDB's BU assignments and our list of valid assemblies, we could easily mark the PDB BU assignments in some special way in the WUI. That way it would be very easy to compare our predictions to the PDB annotations.

I'll assign this to 3.0, but if time is pressing, it can go to 3.1

[Issue split from #54]

@josemduarte
Copy link
Contributor Author

One complication is that some PDB assignments are non-valid topologically, which means that this issue depends on #102.

I'll move this to 3.1 for the moment...

@josemduarte josemduarte modified the milestones: 3.1, 3.0 Apr 7, 2016
@lafita
Copy link
Member

lafita commented Jun 1, 2016

At the moment, the PDB1 BU Annotations are stored in the AssemblyScore table, with score equal to -1 and the call XTAL, if the assembly is not the pdb1, or BIO, if the assembly is the pdb1. This is very memory inefficient and difficult to handle, in case we want to mark the PDB1 assemblies in the wui or query the database.

I propose to introduce an indicator (boolean, bit(1) field) in the Assembly table, where 1 indicates that the assembly is the pdb1 and 0 indicates that the assembly is not the pdb1.

@josemduarte
Copy link
Contributor Author

The current system is indeed a bit redundant. At the same time the advantage is that the current system allows for any arbitrary number of assembly prediction/annotation methods to be stored in the AssemblyScore table, e.g. we can have pdb2, pdb3, etc. (which is something we might want to do, see https://github.com/eppic-team/eppic-science/issues/91)

@josemduarte
Copy link
Contributor Author

I've implemented a basic displaying of the pdb1 biounit assignment by simply showing an icon next to the prediction (the icon is definitely open for improvement). It's in branch issue100, now deployed on dev server.

@josemduarte
Copy link
Contributor Author

I've merged the issue100 branch now.

@josemduarte
Copy link
Contributor Author

I'll close, please open if someone feels like improving the current basic implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants