Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate the sporadic NANs in the stan analytical solutions (all dists) when the cdf is 1 #129

Open
seabbs opened this issue Oct 9, 2024 · 0 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@seabbs
Copy link
Contributor

seabbs commented Oct 9, 2024

Originally posted by @seabbs in #109 (comment)

When we test the analytical solutions in stan against their R equivalents we sometimes see NANs in the stan output that are 1 in the R output. This indicates some kind of overflow or boundary issue to me.

https://github.com/epinowcast/primarycensored/blob/main/tests/testthat/test-stan-primarycensored_analytical_cdf.R

So far we have seen no evidence of this being an issue when fitting models indicating it might be related to our testing setup pushing towards extreme edge cases but regardless this needs investigation.

@seabbs seabbs added bug Something isn't working help wanted Extra attention is needed labels Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant