Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hexSticker in suggests #16

Open
seabbs opened this issue Aug 7, 2023 · 3 comments
Open

hexSticker in suggests #16

seabbs opened this issue Aug 7, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@seabbs
Copy link
Collaborator

seabbs commented Aug 7, 2023

As it is already in its own configuration section it doesn't also need to be in suggests. Same goes for sysfonts.

I also see usethis in there which I wouldn't usually include.

@seabbs seabbs added the enhancement New feature or request label Aug 7, 2023
@pearsonca
Copy link
Collaborator

Given it's own config, sure. But re usethis: my stance is generally anything that isn't used to use the package, but is used for any element of package build/test/etc goes in suggests.

Not sure that's actually the case here for usethis - will have to check. Could well be via data-raw or some such.

@seabbs
Copy link
Collaborator Author

seabbs commented Aug 7, 2023

I think you are using it in data-raw which I would likely give its own config.

@seabbs
Copy link
Collaborator Author

seabbs commented Aug 8, 2023

I also don't really agree that development only packages should be included in suggests - rather they should be a config option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants