Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tabular columns are not checked anymore before training #801

Closed
JulienVig opened this issue Oct 7, 2024 · 1 comment
Closed

Tabular columns are not checked anymore before training #801

JulienVig opened this issue Oct 7, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@JulienVig
Copy link
Collaborator

Connecting a csv missing some expected columns doesn't trigger the previous error message telling the user that some columns are missing (e.g. trying to train after connecting titanic_test.csv instead of titanic_train.csv). An error occurs at training time and doesn't specify what is the problem. Additionally the webapp displays "Training successfully completed" even though an error just occurred.
Screenshot 2024-10-07 at 13 49 53

@tharvik do you think this was introduced in #682?

@JulienVig JulienVig added the bug Something isn't working label Oct 7, 2024
@tharvik
Copy link
Collaborator

tharvik commented Oct 23, 2024

ho, yes that's an issue! I think you're right, it was introduced with the rework of loaders; anyway, it is now fixed with the rework of preprocessing in #781

@tharvik tharvik closed this as completed Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants