Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Autotests: Replace Clear Canvas operations with valid helper functions #6035

Closed
AlexeyGirin opened this issue Dec 2, 2024 · 0 comments · Fixed by #6163
Closed

Autotests: Replace Clear Canvas operations with valid helper functions #6035

AlexeyGirin opened this issue Dec 2, 2024 · 0 comments · Fixed by #6163
Assignees
@knadonenko
Labels
Autotests refactor Code refactoring, without changing the functionality
Milestone
Autotests

Comments

@AlexeyGirin
Copy link
Collaborator

  1. Identify all Clear Canvas operations made by keyboard Control+Delete and by using methods
    page.getByTestId('clear-canvas').click(),
    or similar
    and replace them with proper helper function selectClearCanvasTool(page)

Recommendation: Try to search "page.keyboard.press(" in code.
That could be page.keyboard.press('Control+Delete'); or page.keyboard.press('${modifier}+Delete'); or similar
@AlexeyGirin AlexeyGirin added this to the Autotests milestone Dec 2, 2024
@AlexeyGirin AlexeyGirin added the refactor Code refactoring, without changing the functionality label Dec 3, 2024
@knadonenko knadonenko linked a pull request Dec 17, 2024 that will close this issue
Changing method #6163
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@knadonenko knadonenko

Labels
Autotests refactor Code refactoring, without changing the functionality
Projects
None yet
Milestone
Autotests
Development

Successfully merging a pull request may close this issue.

Changing method epam/ketcher
2 participants
@knadonenko @AlexeyGirin