Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ketcher wrongly collapses customButtons when some of the standard buttons are hidden #6154

Open
BrannJoly opened this issue Dec 13, 2024 · 0 comments

Comments

@BrannJoly
Copy link

Steps to Reproduce

Create a Ketcher with at least two custom buttons and at least one hidden standard button, eg:

  <Editor
        customButtons={[
          {
            id: 'test1,
            title: 'test1',
            imageLink: 'src/assets/common/test1.png',
          },
          {
         id: 'test2,
            title: 'test2',
            imageLink: 'src/assets/common/test2.png',
          },
        ]}
        onInit={initHandler}
        buttons={{
          fullscreen: { hidden: true },
         }}
        staticResourcesUrl={'/'}
        structServiceProvider={structServiceProvider}
        errorHandler={(message: string): void => {
          console.log(message);
        }}

play with the horizontal side of the ketcher. At some point the custom button collapse in a submenu eventhough there's plenty of space available (see screenshot)

This only happens when hiding some of the default buttons. I was not able to reproduce it while using all the standard buttons

Actual behavior
the buttons are collapsed in a submenu eventhough there's enough space available to show them properly
image

Expected behavior
I would have expected all my buttons to show up given enough space was available, like this :

image

Screenshots
image

Desktop (please complete the following information):

  • OS: MacOs
  • Browser: issue happens with Chrome 131.0.6778.140
  • Version 131.0.6778.140
    I also reproduced the issue on firefox

Ketcher version 2.26.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants