Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inability to focus on the drawing entity within expanded S-group/monomer bounding box #5910

Closed
svvald opened this issue Nov 4, 2024 · 1 comment · Fixed by #6069, #6137 or #6139
Closed

Inability to focus on the drawing entity within expanded S-group/monomer bounding box #5910

svvald opened this issue Nov 4, 2024 · 1 comment · Fixed by #6069, #6137 or #6139
Assignees
@svvald
Labels
bug Priority: High
Milestone
Ketcher 2.27.0-rc.3

Comments

@svvald
Copy link
Collaborator

svvald commented Nov 4, 2024 •
edited
Loading

Once monomer is expanded in micromolecules mode, it's impossible to focus on the other monomer/s-group which is placed within expanded monomer's bounding box unless expanded monomer is moved which makes it unconvenient to use.
image
Hovering over such monomers/s-groups has to be prioritized so they will be highlighted/focused first even being placed within expanded monomer bounding box
@svvald svvald added this to the Ketcher 2.27.0-rc.2 milestone Nov 4, 2024
@svvald svvald self-assigned this Nov 4, 2024
svvald added a commit that referenced this issue Dec 5, 2024
@svvald
#5910 – Fix closest sgroup detection to allow focusing on entities wi…
52720b0 
…thin expanded monomer's bounding box
@svvald svvald linked a pull request Dec 6, 2024 that will close this issue
#5910 – Fix closest sgroup detection to allow focusing on entities within expanded monomer's bounding box #6069
Merged
9 tasks
svvald added a commit that referenced this issue Dec 9, 2024
@svvald
#5910 – Fix on checking sgroups map
e53cdb5
svvald added a commit that referenced this issue Dec 10, 2024
@svvald
#5910 – Fix closest sgroup detection to allow focusing on entities wi…
47f36f4 
…thin expanded monomer's bounding box
svvald added a commit that referenced this issue Dec 10, 2024
@svvald
#5910 – Fix on checking sgroups map
5654d9b
svvald added a commit that referenced this issue Dec 11, 2024
@svvald
#5910 – Fix ui test and erasing contracted sgroup
7dde207
svvald added a commit that referenced this issue Dec 11, 2024
@svvald
#5910 – Fix closest sgroup detection to allow focusing on entities wi…
5009d97 
…thin expanded monomer's bounding box (#6069)

* #5910 – Fix closest sgroup detection to allow focusing on entities within expanded monomer's bounding box

* #5910 – Fix on checking sgroups map

* #5910 – Fix ui test and erasing contracted sgroup
svvald added a commit that referenced this issue Dec 11, 2024
@svvald
#5910 – Fix closest sgroup detection to allow focusing on entities wi…
056d0ac 
…thin expanded monomer's bounding box (#6069)

* #5910 – Fix closest sgroup detection to allow focusing on entities within expanded monomer's bounding box

* #5910 – Fix on checking sgroups map

* #5910 – Fix ui test and erasing contracted sgroup
svvald added a commit that referenced this issue Dec 11, 2024
@svvald
Backmerge: #5910 – Fix closest sgroup detection to allow focusing on …
29a1fbb 
…entities within expanded monomer's bounding box
svvald added a commit that referenced this issue Dec 11, 2024
@svvald
Backmerge: #5910 – Fix closest sgroup detection to allow focusing on …
f436a7e 
…entities within expanded monomer's bounding box
This was linked to pull requests Dec 20, 2024
Backmerge: #5910 – Fix closest sgroup detection to allow focusing on entities within expanded monomer's bounding box #6137
Merged
Backmerge: #5910 – Fix closest sgroup detection to allow focusing on entities within expanded monomer's bounding box #6139
Merged
svvald added a commit that referenced this issue Dec 25, 2024
@svvald
Backmerge: #5910 – Fix closest sgroup detection to allow focusing on …
64e7a38 
…entities within expanded monomer's bounding box
@AlexeyGirin
Copy link
Collaborator

Verified.
image

  • Ketcher Version 2.27.0-rc.3 Build at 2024-12-25; 10:08:04
  • Indigo Version 1.26.0-rc.5.0-g42ee8510b-wasm32-wasm-clang-19.0.0
  • Chrome Version 131.0.6778.205 (Official Build) (64-bit)
  • Win10

svvald added a commit that referenced this issue Dec 25, 2024
@svvald
Backmerge: #5910 – Fix closest sgroup detection to allow focusing on …
07d3cf3 
…entities within expanded monomer's bounding box (#6137)
svvald added a commit that referenced this issue Dec 25, 2024
@svvald
Backmerge: #5910 – Fix closest sgroup detection to allow focusing on …
03f783e 
…entities within expanded monomer's bounding box
svvald added a commit that referenced this issue Dec 25, 2024
@svvald
Backmerge: #5910 – Fix closest sgroup detection to allow focusing on …
de3eecc 
…entities within expanded monomer's bounding box (#6139)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@svvald svvald

Labels
bug Priority: High
Projects
None yet
Milestone
Ketcher 2.27.0-rc.3
3 participants
@svvald @rrodionov91 @AlexeyGirin