-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(chat): fix modal displaying logic (Issue #2878) #3088
Open
IlyaBondar
wants to merge
21
commits into
development
Choose a base branch
from
fix/2878-fix-modals
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+154
−118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto modal-import
IlyaBondar
added
bug
Something isn't working
enhancement
New feature or request
technical debt
labels
Feb 3, 2025
IlyaBondar
requested review from
Gimir,
denys-kolomiitsev,
Alexander-Kezik,
Derikyan and
likeamike
as code owners
February 3, 2025 18:37
/deploy-review
|
/deploy-review
|
/deploy-review
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
fix modal displaying logic
Issues:
Checklist:
fix(<scope>):
,feat(<scope>):
,feature(<scope>):
,chore(<scope>):
,hotfix(<scope>):
ore2e(<scope>):
. If contains breaking changes then the pull request name must start withfix(<scope>)!:
,feat(<scope>)!:
,feature(<scope>)!:
,chore(<scope>)!:
,hotfix(<scope>)!:
ore2e(<scope>)!:
where<scope>
is name of affected project:chat
,chat-e2e
,overlay
,shared
,sandbox-overlay
, etc.(Issue #<TICKET_ID>)
(comma-separated list of issues)