Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply discount_factor to gas parameters #174

Open
Tracked by #291
stephenpdeos opened this issue Jun 27, 2024 · 0 comments · May be fixed by #215
Open
Tracked by #291

Apply discount_factor to gas parameters #174

stephenpdeos opened this issue Jun 27, 2024 · 0 comments · May be fixed by #215
Assignees

Comments

@stephenpdeos
Copy link
Member

stephenpdeos commented Jun 27, 2024

  • Assign proper value to the discount_factor when gas_parameters is initialized
  • Note: this factor is NOT a consensus parameter
  • Access the gas_params with or without discount in different places (e.g. estimate_gas without discount)
  • Note: Be careful about G_SSET as there is a pre-computed table that needs to be looked into

Depends on eosnetworkfoundation/eos-evm-contract#744 and eosnetworkfoundation/evmone#9

@stephenpdeos stephenpdeos converted this from a draft issue Jun 27, 2024
@stephenpdeos stephenpdeos added this to the Silkworm v2.0.0 milestone Oct 23, 2024
@elmato elmato linked a pull request Oct 28, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Awaiting Review
Development

Successfully merging a pull request may close this issue.

2 participants