Start HTTP server for management server in int tests #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Believe this is the cause of the flakiness, due to shared ports with the upstream HTTP server in the e2e tests. Signed-off-by: Jess Yuen <[email protected]>
|
@jessicayuen , can you clarify why you think that starting the upstream http server fixes the underlying problem? Did you see my comment in the issue? If so, which one of the 2 failures this fix addresses? |
LisaLudique
reviewed
May 14, 2020
| @@ -205,11 +206,12 @@ func setup( | |||
| srv3 := gcpserverv3.NewServer(ctx, nil, nil) | |||
|
|
|||
| // Start the origin server | |||
| go gcptest.RunManagementServer(ctx, srv2, srv3, originServerPort) | |||
| go gcptest.RunHTTP(ctx, originServerHTTPPort) | |||
There was a problem hiding this comment.
What's the distinction between these two servers / why does the origin server need both ports?
|
Going to close this. This is the wrong approach and I think a coincidence that the test is passing. Integration tests shouldn't require the HTTP service because there is no Envoy making the outbound calls. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Believe this is the cause of the flakiness, due to shared ports with the
upstream HTTP server in the e2e tests.
Signed-off-by: Jess Yuen [email protected]