You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
After #855 is pushed through, these two filters now have their own configuration for starting up the filters, without any internal references to ResponseOptions.proto. However, the header override api still requires their fields to exist on ResponseOptions.proto, because the ResponseOptions proto is what is passed through the x-nighthawk-test-server-config header.
In order to move off this, we should:
Introduce three separate headers, one for each configuration (or one new header with three subsets of configuration). The current header will then become a legacy header and will issue warnings
Introduce a flag that makes only the new headers work
Remove the old header completely.
The text was updated successfully, but these errors were encountered:
After #855 is pushed through, these two filters now have their own configuration for starting up the filters, without any internal references to ResponseOptions.proto. However, the header override api still requires their fields to exist on ResponseOptions.proto, because the ResponseOptions proto is what is passed through the
x-nighthawk-test-server-config
header.In order to move off this, we should:
The text was updated successfully, but these errors were encountered: