Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error message when terminating due to a predicate #826

Open
mum4k opened this issue Apr 12, 2022 · 1 comment
Open

Improve error message when terminating due to a predicate #826

mum4k opened this issue Apr 12, 2022 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@mum4k
Copy link
Collaborator

mum4k commented Apr 12, 2022

Nighthawk will sometimes terminate some of its worker threads early, before the specified --duration has elapsed. It reports the error:

[E] Exiting due to failing termination predicate

This error message should tell the user which termination predicate failed, that is, which counter was exceeded, and what its final value was.

This would be useful debugging information because the user may have specified multiple termination predicates.
@mum4k mum4k added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Apr 12, 2022
@jmarantz
Copy link

@mergeconflict

@mum4k mum4k mentioned this issue Jun 7, 2023
Merged
mum4k pushed a commit that referenced this issue Jun 12, 2023
@mergeconflict
Allow disabling default failure predicates. (#997)
8da4c81 
Works on #826 

Signed-off-by: Dan Rosen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jmarantz @mum4k