Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VHost metadata in logs and attributes #34900

Closed
2 tasks done
guydc opened this issue Jun 25, 2024 · 6 comments
Closed
2 tasks done

VHost metadata in logs and attributes #34900

guydc opened this issue Jun 25, 2024 · 6 comments
Labels
area/access_log help wanted Needs help!

Comments

@guydc
Copy link
Contributor

guydc commented Jun 25, 2024 •
edited
Loading

Title: VHost metadata in logs and attributes

Description:
Envoy resource metadata (e.g. route, cluster and listener metadata) is typically supported in the following:

VHost metadata was introduced in #30175. VHost metadata should also support these capabilities.

Relevant Links:
@guydc guydc added enhancement Feature requests. Not bugs or questions. triage Issue requires triage labels Jun 25, 2024
@guydc guydc mentioned this issue Jun 25, 2024
Closed
@mattklein123 mattklein123 added help wanted Needs help! area/access_log and removed enhancement Feature requests. Not bugs or questions. triage Issue requires triage labels Jun 25, 2024
@mathetake mathetake mentioned this issue Jun 27, 2024
Merged
@mathetake
Copy link
Member

I just opened the PR for this: #34958

wbpcode pushed a commit that referenced this issue Jul 11, 2024
@mathetake
formatter: support for virtual host metadata (#34958)
1f79be9 
Commit Message: formatter: support for virtual host metadata
Additional Description:
This enables the access to the virtual host metadata introduced in
#30175 from formatter.

Risk Level: low 
Testing: : unit test
Docs Changes: done.
Release Notes:  
Platform Specific Features:
[Optional Fixes #Issue] #34900

---------

Signed-off-by: Takeshi Yoneda <[email protected]>
update-envoy bot added a commit to envoyproxy/data-plane-api that referenced this issue Jul 11, 2024
@update-envoy
formatter: support for virtual host metadata (#34958)
0cf08d4 
Commit Message: formatter: support for virtual host metadata
Additional Description:
This enables the access to the virtual host metadata introduced in
envoyproxy/envoy#30175 from formatter.

Risk Level: low
Testing: : unit test
Docs Changes: done.
Release Notes:
Platform Specific Features:
[Optional Fixes #Issue] envoyproxy/envoy#34900

---------

Signed-off-by: Takeshi Yoneda <[email protected]>

Mirrored from https://github.com/envoyproxy/envoy @ 1f79be9c21d4a343f68e8fba41f5a819300cb27f
@mathetake
Copy link
Member

merged and can be closed 😉

@guydc
Copy link
Contributor Author

guydc commented Jul 11, 2024 •
edited
Loading

Hi @mathetake !

Thanks for implementing the Access Log formatter part. Does the PR also cover:

Attributes: metadata can be accessed through an attribute (xds.*_metadata)

@mathetake
Copy link
Member

the PR is not limited to access log, but wherever the METADATA( substitution is used

@mathetake
Copy link
Member

yeah, I think the second one is not implemented (though I am not knowledgeable on that part)

@guydc
Copy link
Contributor Author

guydc commented Feb 3, 2025

thanks @wbpcode for implementing the attributes part in #37650.

@guydc guydc closed this as completed Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/access_log help wanted Needs help!
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mattklein123 @mathetake @guydc