Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Python 2 support #120

Closed
mdickinson opened this issue Jun 1, 2020 · 3 comments
Closed

Drop Python 2 support #120

mdickinson opened this issue Jun 1, 2020 · 3 comments

Comments

@mdickinson
Copy link
Member

We no longer need to support Python 2; related code can be dropped.

@aaronayres35
Copy link
Contributor

What is the status of this issue? I'm not sure what else needs to be done to say we have officially dropped python 2 support

@mdickinson
Copy link
Member Author

It's looking good; getting rid of six was the single biggest thing (done in #230).

Taking a quick look, I spotted a couple of leftovers (but maybe there's still a sweet_pickle PR pending?)

  • there's still one from __future__ import print_function in apptools/sweet_pickle/tests
  • there's an if sys.version_info[0] >= 3: in the apptools/sweet_pickle/versioned_unpickler.py

@mdickinson
Copy link
Member Author

but maybe there's still a sweet_pickle PR pending?

Ah yes: #199. I'll close this, then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants