Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add convenience option to convert to naive local time in TimeseriesData.to_dataframe() #33

Open
daniel-k opened this issue Dec 7, 2023 · 6 comments

Comments

@daniel-k
Copy link
Member

daniel-k commented Dec 7, 2023

From #32 (comment) we learned, that for interactive exploration it is inconvenient to return UTC-based, aware timestamps. Let's optimize for convenience add an option to return naive, localized timestamps instead.

@clehensen
Copy link
Contributor

Thank you for creating the issue. An important aspect to keep in mind: the local timezone should be the one where the machine/site is located, and not the browser locale.

@daniel-k
Copy link
Member Author

daniel-k commented Dec 7, 2023

That's a really good point! However, it makes the problem quite a bit harder for us, since we don't explicitly have information about the timezone currently, just the postal address of a site. We'd probably need to integrate some external API to turn that into a timezone or we add that atteribute explicitly to a site 🤔

@clehensen
Copy link
Contributor

I think adding it explicitly to a site would work well.

@daniel-k
Copy link
Member Author

daniel-k commented Dec 7, 2023

CC @cipherself @denizs

@denizs
Copy link
Member

denizs commented Dec 7, 2023

Another option I'd like to throw in: What about adding another datetime index that consists of naive localized datetimes?

the local timezone should be the one where the machine/site is located, and not the browser locale.

We don't have any users outside the timezone of the production sites. Thus, right now (and I assume for the foreseeable future), this is equal to localizing the datetime to the user's locale. Let's talk about the benefits of this f2f to figure out a way forward.

@clehensen
Copy link
Contributor

I don't see browser locale as a workable short-term option

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants