Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some improvement points #229

Open
amrezaee opened this issue Oct 20, 2022 · 0 comments
Open

some improvement points #229

amrezaee opened this issue Oct 20, 2022 · 0 comments

Comments

@amrezaee
Copy link

Hi.
I'm using your lib and it's great but some problems exist.
It's a good thing to add #ifndef before NOMINMAX & WIN32_LEAN_AND_MEAN to prevent macro redefinition in environments where those two are defined.
may be add green color to Info verbosity like many other logging libs or provide a way to customize verbosity colors.
and does logging macros by default support c++ types like string or filesystem::path? i tried it, it worked but i get some portability warnings and supporting that types is a good feature.
thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant