-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When moving with the animation function of ScrollArea
, it does not move to the exact location.
#5289
Comments
Can you explain further or show a example of how to reproduce the bug? In your PR you just made it so you can't make any changes to the scroll target while a animation is running, I don't think that can be a solution. But I did notice this behavior if you repeatedly click the scroll by button, it will stutter and accelerate / decelerate, while I would expect a relatively constant and smooth animation, is this what you mean? Bildschirmaufnahme.2024-10-20.um.17.06.02.mov |
In order to reproduce the bug or show an example, I need to create a sample test program for a few days, but I don't have time right now. To put it simply, when I search for a character in TextEdit and scroll to that position using In my opinion, it's best to disable the animation feature if we need to keep calling Rather than making another scroll while scrolling, it would be better to increase the scroll speed so that the scroll ends sooner. |
If you call scroll_with_delta repeatedly I think it makes sense that it might not reach any predictable location. But it shouldn't be a problem to call
As a user I would always want the last scroll to succeed. If there is e.g. a search bar that scrolls to results as I am typing, it may not ignore the last scroll_to request.
if the second call is ignored because a animation is still in progress the user would now be scrolled to PS I wonder what text would contain both eggs and egui 😄 |
Dear lucasmerlin & Dear emilk Here is a more detailed explanation. If you separate If you separate I have created the following example program to test this.
|
Dear lucasmerlin & Dear emilk If there is a new scroll during the scroll animation, it has been fixed in #5307 to move to that location. |
When using the animation feature of the
ScrollArea
, it does not move to the correct location.There is a part that is interfering incorrectly during the animation process.
The text was updated successfully, but these errors were encountered: