You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The "replacement" field in the deprecation tagging was left blank, perhaps because of the aforementioned (presumed) minimal use of the API. The discussion in #404 makes the somewhat-cryptic suggestion, "[uses of this API] should probably be a gresourced style sheet instead as we've done in other apps".
The PR to actually replace the referenced instance (elementary/files#1376) is more enlightening, replacing a call to Gtk.Widgets.Utils.set_theming with the following:
Set the deprecation tag replacement field for set_theming and related API deprecations to something like "Gtk.CssProvider and Gtk.StyleContext.add_provider", to provide remaining callers with information on implementing a similar fix in their own code.
Prior Art
The text was updated successfully, but these errors were encountered:
Problem
Utils.set_theming
was deprecated (in #404). The claim at the time was that it was basically-unused.As @jeremypw pointed out at the time, there is additional use of that API in third-party apps, something a github-wide search for
Granite.Widgets.Utils.set_theming
confirms.The "replacement" field in the deprecation tagging was left blank, perhaps because of the aforementioned (presumed) minimal use of the API. The discussion in #404 makes the somewhat-cryptic suggestion, "[uses of this API] should probably be a gresourced style sheet instead as we've done in other apps".
The PR to actually replace the referenced instance (elementary/files#1376) is more enlightening, replacing a call to
Gtk.Widgets.Utils.set_theming
with the following:Proposal
Set the deprecation tag
replacement
field forset_theming
and related API deprecations to something like"Gtk.CssProvider and Gtk.StyleContext.add_provider"
, to provide remaining callers with information on implementing a similar fix in their own code.Prior Art
The text was updated successfully, but these errors were encountered: