Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat DM rooms with bridge bots as People using MSC4171 service member functionality #4034

Open
frebib opened this issue Dec 13, 2024 · 1 comment
Labels
T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements

Comments

@frebib
Copy link
Contributor

frebib commented Dec 13, 2024

Your use case

What would you like to do?

Have DM rooms (2 users + a bridge bot) show up in the People filter just like they do in other Matrix clients
using MSC4171

Why would you like to do it?

Because bridged users are people too. It provides a consistent (and more importantly) intuitive experience

How would you like to achieve it?

Adjust the isDm() check here:


to use the recently implemented service_members functionality in Rust SDK added in matrix-org/matrix-rust-sdk#4335. Whilst matrix-org/matrix-rust-sdk#4335 fixes the room name for bridged rooms, it doesn't expose the required information through the SDK FFI layer for the app to know which users in a room are service members.

I'm asking here if this seems like a reasonable thing to do given how Element wants to frame DM chats, and whether approach is considered acceptable. I'm happy to attempt some of the implementation for this

Have you considered any alternatives?

I have a hacky patch that achieves roughly the same thing, but it's awful and not a good way to solve this frebib@e5a5acc

Additional context

No response

Are you willing to provide a PR?

Yes

@frebib frebib added the T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements label Dec 13, 2024
@frebib frebib changed the title https://github.com/element-hq/element-x-android/blob/b2a9ebb2d25da51a13627cca06ef7e86a4697ab8/libraries/matrix/api/src/main/kotlin/io/element/android/libraries/matrix/api/room/RoomIsDmCheck.kt#L18 Treat DM rooms with bridge bots as People using MSC4171 service member functionality Dec 13, 2024
@frebib
Copy link
Contributor Author

frebib commented Dec 13, 2024

It also just occurred to me that perhaps this information might also be used to render something in the room member list as per the MSC

Clients may include some special label for service members in the member list and/or other places in the room to make it clearer why they're not included in the room name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements
Projects
None yet
Development

No branches or pull requests

1 participant