Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reaction emoji picker has no search #1611

Open
frebib opened this issue Oct 19, 2023 · 2 comments · May be fixed by #2892
Open

Reaction emoji picker has no search #1611

frebib opened this issue Oct 19, 2023 · 2 comments · May be fixed by #2892
Labels
A-Reactions O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements

Comments

@frebib
Copy link
Contributor

frebib commented Oct 19, 2023 •
edited
Loading

Your use case

What would you like to do?

Be able to search for emojis by name

Why would you like to do it?

Because picking emojis by scrolling for 60 seconds is insane

How would you like to achieve it?

With my fingers

Have you considered any alternatives?

No

Additional context

Element Android has this, so it would add parity

Are you willing to provide a PR?

Yes
@frebib frebib added the T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements label Oct 19, 2023
@kittykat kittykat added S-Major Severely degrades major functionality or product features, with no satisfactory workaround O-Occasional Affects or can be seen by some users regularly or most users rarely A-Composer A-Reactions and removed A-Composer labels Oct 24, 2023
@kittykat kittykat changed the title Emoji picker has no search Reaction emoji picker has no search Oct 24, 2023
@torrybr
Copy link
Contributor

torrybr commented Nov 2, 2023 •
edited
Loading

Is there a reason X doesnt use the emoji2 kotlin package? Looks like you get alot of features for free like recents, updated emojis, and a consistent experience. https://developer.android.com/develop/ui/views/text-and-emoji/emoji-picker

I would be interested in contributing to this if the developers had a ticket open with some direction or guidance on how they wanted it implemented! Ex. Reuse the SearchBar component and make it look like xyz

@cyrneko
Copy link

cyrneko commented Feb 22, 2024

Is there a reason X doesnt use the emoji2 kotlin package? Looks like you get alot of features for free like recents, updated emojis, and a consistent experience. https://developer.android.com/develop/ui/views/text-and-emoji/emoji-picker

I would be interested in contributing to this if the developers had a ticket open with some direction or guidance on how they wanted it implemented! Ex. Reuse the SearchBar component and make it look like xyz

Note that you'd still need to work around some things in this package, like parsing the account data to get the recent emojis from the server, to have them synced with other Element clients.

@frebib frebib linked a pull request May 21, 2024 that will close this issue
Draft
14 tasks
frebib pushed a commit to ChelseaDH/element-x-android that referenced this issue May 21, 2024
@ChelseaDH @frebib
Reaction emoji picker search/filtering
6fa81b8 
Fixes: element-hq#1611
Co-Authored-by: Chelsea Hilditch <[email protected]>
Signed-off-by: Joe Groocock <[email protected]>
@jmartinesp jmartinesp linked a pull request May 22, 2024 that will close this issue
Reaction emoji search / Sending freeform reactions #2892
Draft
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Reactions O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Reaction emoji search / Sending freeform reactions ChelseaDH/element-x-android
4 participants
@kittykat @frebib @torrybr @cyrneko