From 709348423e0f0e4d3bf2014ee2d53a356a7af469 Mon Sep 17 00:00:00 2001 From: David Sanders Date: Mon, 21 Aug 2023 23:24:06 -0700 Subject: [PATCH 1/4] ci: use electronjs/node orb --- .circleci/config.yml | 40 ++++++++++++++++++++++------------------ 1 file changed, 22 insertions(+), 18 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 1aa2d50..7773498 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -1,29 +1,33 @@ version: 2.1 + orbs: cfa: continuousauth/npm@1.0.2 -jobs: - test: - docker: - - image: cimg/node:18.11.0 - steps: - - checkout - - restore_cache: - key: dependency-cache-{{ checksum "yarn.lock" }} - - run: yarn --frozen-lockfile - - save_cache: - key: dependency-cache-{{ checksum "yarn.lock" }} - paths: - - ./node_modules - - run: yarn lint - - run: yarn test + node: electronjs/node@1.1.0 + workflows: test_and_release: - # release when tests are successful + # Run the test jobs first, then the release only when all the test jobs are successful jobs: - - test + - node/test: + executor: node/macos + name: test-mac-<< matrix.node-version >> + test-steps: + - run: yarn lint + - run: yarn test + use-test-steps: true + matrix: + alias: test-mac + parameters: + node-version: + - 20.5.0 + - 18.17.0 + - 16.20.1 + - 14.21.3 + - 12.22.12 + - 10.24.1 - cfa/release: requires: - - test + - test-mac filters: branches: only: From 242ba2a2c914cd2c208bcc780636bc38b2e3a63a Mon Sep 17 00:00:00 2001 From: David Sanders Date: Mon, 21 Aug 2023 23:38:00 -0700 Subject: [PATCH 2/4] ci: tweak config --- .circleci/config.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 7773498..3378dfd 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -2,7 +2,7 @@ version: 2.1 orbs: cfa: continuousauth/npm@1.0.2 - node: electronjs/node@1.1.0 + node: electronjs/node@1.2.0 workflows: test_and_release: @@ -11,6 +11,7 @@ workflows: - node/test: executor: node/macos name: test-mac-<< matrix.node-version >> + override-ci-command: yarn install --frozen-lockfile --ignore-engines test-steps: - run: yarn lint - run: yarn test From 00a717090fd96f3d7b3f4f66ed4ee0efeae0adff Mon Sep 17 00:00:00 2001 From: David Sanders Date: Mon, 21 Aug 2023 23:56:04 -0700 Subject: [PATCH 3/4] ci: can't test older Node.js --- .circleci/config.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 3378dfd..70eae53 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -24,8 +24,8 @@ workflows: - 18.17.0 - 16.20.1 - 14.21.3 - - 12.22.12 - - 10.24.1 + # - 12.22.12 + # - 10.24.1 - cfa/release: requires: - test-mac From 1fbd8262e80ccf8ba7a577bd70a76274978eae76 Mon Sep 17 00:00:00 2001 From: David Sanders Date: Thu, 24 Aug 2023 18:19:10 -0700 Subject: [PATCH 4/4] ci: bump orb version --- .circleci/config.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 70eae53..61dfe9d 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -2,7 +2,7 @@ version: 2.1 orbs: cfa: continuousauth/npm@1.0.2 - node: electronjs/node@1.2.0 + node: electronjs/node@1.4.1 workflows: test_and_release: