Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plain text error output from xcrun is not handled #177

Closed
jasonrm opened this issue Feb 6, 2024 · 5 comments
Closed

Plain text error output from xcrun is not handled #177

jasonrm opened this issue Feb 6, 2024 · 5 comments

Comments

@jasonrm
Copy link

jasonrm commented Feb 6, 2024

The JSON parsing of the xcrun output added in #173 doesn't handle an unaccepted program license agreement with Apple.

with v2.2.1

  ⨯ Unexpected token E in JSON at position 0  failedTask=build stackTrace=SyntaxError: Unexpected token E in JSON at position 0
    at JSON.parse (<anonymous>)
    at /Users/runner/work/repo/node_modules/@electron/notarize/src/notarytool.ts:79:25
    at Generator.next (<anonymous>)
    at fulfilled (/Users/runner/work/repo/node_modules/@electron/notarize/lib/notarytool.js:28:58)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)

with v2.1.0

  ⨯ Failed to notarize via notarytool
Error: HTTP status code: 403. A required agreement is missing or has expired. This request requires an in-effect agreement that has not been signed or has expired. Ensure your team has signed the necessary legal agreements and that they are not expired.
  failedTask=build stackTrace=Error: Failed to notarize via notarytool
@JamesS-M
Copy link

I'm experiencing this same problem.

@ericvanbuhler
Copy link

ericvanbuhler commented Mar 26, 2024

I'm experiencing the same issue on v2.3.0

@Makio64
Copy link

Makio64 commented Mar 31, 2024

same issue here

@yingchen-liu
Copy link

Same here

@rotu
Copy link
Contributor

rotu commented May 15, 2024

This should be fixed by #191

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants