Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Multiple Installed Versions #87

Open
dsanders11 opened this issue Jul 11, 2023 · 0 comments
Open

Allow Multiple Installed Versions #87

dsanders11 opened this issue Jul 11, 2023 · 0 comments
Labels
area:versions ✨ enhancement New feature or request

Comments

@dsanders11
Copy link
Member

Currently fiddle-core continually swaps the installed version (via Installer) into Paths.electronInstall as needed. Fiddle can have multiple windows, each with a different version of Electron selected. These two paradigms are at odds with each other since running two different fiddles with different Electron versions will cause the second run to try to replace the files of the first one.

The current approach has the distinct advantage that there's only ever one installed version extracted on disk, so even if no cleanup is performed, at worse the files for a single version remain extracted. The limitation on multiple installed versions is somewhat problematic, though. A better default behavior may be to use temp directories and have Runner remove them as clean up. This would be a breaking change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:versions ✨ enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant