-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apple notarize returns multiple errors on the pkg #6607
Comments
Not sure I can help much here, electron-builder uses the core package https://github.com/electron/electron-osx-sign underneath, so we're just running that on top of the packaged dist. And not sure how you've set up your electron-notarize either What build machine are you using? Apple Silicon/M1? |
Hi @mmaietta. ABOUT THE SIGNATUREThe In order to check that the pkg is actually signed I've used the macOS
However when trying to notarize I get the requiest as denied, and the logs presented above in the description of the issue. ABOUT ELECTRON NOTARIZE CODEHighly inspired in the post you point out in your own docs -> https://kilianvalkhof.com/2019/electron/notarizing-your-electron-application/ After the build is done I invoke
ABOUT MY COMPUTERMy computer is Apple silicon -> 2,3 GHz Quad-Core Intel Core i7 SUMARIZING
But there is something wrong in the built process Thanks a lot for looking into that |
Hmmm, I have the same notarization setup. If you use patch-package you can create this patch to force all packages to be signed. It'd at least unblock you for the interim. I don't know why (or how) the signing works on
|
Hi @mmaietta thank you very much for your answer I just applied the patch I first would like to be sure that I've applied the patch correctly
Was my assumption right? Is there something else I had to do? |
Also I wonder...have you ever tested notarizing a pkg file? |
Hi @mmaietta I've tried notarizing a pkg file
So far I have no other conclusion than electron builder is building the 3 solutions sign the 3 solutions fail in exact the same way 🐛 🐛 🐛 👇 👇 👇 👇 👇 👇 👇
Talked with Any ideas? |
I've never released a .pkg before, so I'm starting to think that either electron-notarize or electron-osx-sign don't support it? |
@mmaietta I'm starting to think it's an issue on electron-builder and the pkg file that builds Could you read this comment? In short generate a pkg file with electron builder
What do you guys think is happening? Isn't it the common factor here the |
If you're signing it manually and manually notarizing with the same errors that signing via electron-builder is, then that sounds pretty affirming that it isn't related to electron-builder. How did you send to notarization manually? Did you use |
Hi @mmaietta thanks for your answer But....Whether
I get the same series of errors from apple notarisation service Doesn't this mean that there is something wrong with the PKG? It looks to me that it doesn't matter what I do or how I do it. The approach I follow, the result from apple notarisation service is always the same (Look at #6607 (comment))
To answer your question
I Followed these steps to do the whole manual process of Signing + Notarising the PKG file |
I'm sorry to say, I don't understand what is going wrong. If it happens both manually and automatically (via electron-builder), then there isn't much I can assist with. |
But...it happens with the PKG generated by electron builder |
Electron builder system is just a toy and not supposed to be used under production. For example there's NOT even one VALID example or toturial to show how to submit to MAS. So drop it and dont waste your time on it. |
The pkg file built is not accepted by apple notarise service
The text was updated successfully, but these errors were encountered: