Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use only mapping for addressOwnershipProofs #11

Open
sebastiantf opened this issue Feb 26, 2024 · 0 comments
Open

Use only mapping for addressOwnershipProofs #11

sebastiantf opened this issue Feb 26, 2024 · 0 comments

Comments

@sebastiantf
Copy link
Collaborator

Description

Currently both the array addressOwnershipProofs and the mapping _ownershipProofByAddress are being used to track address ownership proofs. But the use of both seems unnecessary, inefficient and error-prone.

Didn't really notice any specific use-case being served by the array.

If there isn't really any use of the array, then I suppose we could remove the array, modify the mapping to store the AddressOwnershipProof struct and only use that. This is probably going to be a lot more efficient and simpler

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant