Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PWA manifest file using gatsby-plugin-manifest. (see: https://www.gatsbyjs.org/docs/add-a-manifest-file/) #11

Closed
0pdd opened this issue Mar 17, 2019 · 1 comment
Closed

Add PWA manifest file using gatsby-plugin-manifest. (see: https://www.gatsbyjs.org/docs/add-a-manifest-file/) #11

0pdd opened this issue Mar 17, 2019 · 1 comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed ☆ This have to be done before going live

Comments

@0pdd
Copy link

0pdd commented Mar 17, 2019

The puzzle 1-9f3e7e67 from #1 has to be resolved:

https://github.com/codeforthailand/election-live/blob/52d8590c6a770be88969d210a0c4fe2974919906/gatsby-config.js#L19-L20

The puzzle was created by Thai Pangsakulyanont on 17-Mar-19.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.
0pdd referenced this issue Mar 17, 2019
@dtinth
Add TODO about Progressive Web App manifest file
52d8590
@0pdd 0pdd mentioned this issue Mar 17, 2019
Open
@dtinth dtinth added good first issue Good for newcomers help wanted Extra attention is needed labels Mar 18, 2019
@dtinth dtinth added the ☆ This have to be done before going live label Mar 19, 2019
@0pdd
Copy link
Author

0pdd commented Mar 20, 2019

The puzzle 1-9f3e7e67 has disappeared from the source code, that's why I closed this issue.

@0pdd 0pdd closed this as completed Mar 20, 2019
0pdd referenced this issue Mar 20, 2019
@dtinth
Merge pull request #56 from NesChaiyapon/nes/add-manifest-plugin
74a7f52 
Add gatsby-plugin-manifest to the project
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed ☆ This have to be done before going live
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dtinth @0pdd