Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement filtering code for Landslide Winning zones #104

Open
rapee opened this issue Mar 23, 2019 · 5 comments
Open

Implement filtering code for Landslide Winning zones #104

rapee opened this issue Mar 23, 2019 · 5 comments

Comments

@rapee
Copy link
Contributor

rapee commented Mar 23, 2019

5. เขตที่ชนะขาด

เขตที่คะแนนของผู้สมัครอันดับ 1 ห่างจากอับดับ 2 เกิน 50%

This is a dynamic filter that filter zones depending on their performances.

image

@rapee rapee changed the title Implement code for Landslide Winning zones Implement filtering code for Landslide Winning zones Mar 23, 2019
@unnawut
Copy link
Contributor

unnawut commented Mar 23, 2019

I'm trying out this issue. Will report back in 1-2 hours.

@unnawut
Copy link
Contributor

unnawut commented Mar 23, 2019

Question: I looked at #22 and I suppose this filter should be derived the same way, so...

  1. The information should be derived from https://www.ect.go.th/ect_th/ewt_dl_link.php?nid=2236 ?
  2. The link above contains only the results separated by constituency seats and party list seats. Should I use either of them or combined?
  3. I guess there's already machine-readable data somewhere? 😅

Thanks!

@unnawut
Copy link
Contributor

unnawut commented Mar 23, 2019

Looks like there's not enough information to derive this based on the available fixtures.

I'm backing down from this issue.

@whs
Copy link
Contributor

whs commented Mar 24, 2019

I think this has to be implemented by filtering the live results?

Looking through src/models/ElectionDataSource.d.ts it seems that the only place where each candidate score is available is through PerProvinceJSON, which we can't use for filtering. There should be a server side filter to add this information to ZoneStats first

@unnawut
Copy link
Contributor

unnawut commented Mar 24, 2019

You are right. I believe @phoneee is working on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants