Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Allow to increase WEBDRIVER_TIMEOUT? #212

Open
olifre opened this issue Jan 21, 2024 · 4 comments
Open

Feature: Allow to increase WEBDRIVER_TIMEOUT? #212

olifre opened this issue Jan 21, 2024 · 4 comments

Comments

@olifre
Copy link
Contributor

olifre commented Jan 21, 2024

Currently, the WEBDRIVER_TIMEOUT seems hardcoded in dnstwist.

This causes flakiness with one of the pages I test, which sometimes has very complex javascript-rich content (sadly), and dnstwist errors out with:

fetching content from: http://uni-bonn.de/ > https://www.uni-bonn.de/en [110.4 KB]
rendering web page: http://uni-bonn.de/
Message: timeout: Timed out receiving message from renderer: 4.154
  (Session info: headless chrome=116.0.5845.180)

Would it be possible to add an option to increase this timeout when required?

(I hope this is the correct timeout I am looking at)

@olifre
Copy link
Contributor Author

olifre commented Jan 21, 2024

Note: In case you want to reproduce, this was executed using the latest official docker container (phash flavour), on GitHub actions. The same test worked fine a day before, so it seems to me that this is related to site complexity and server performance on the site end, which could match hitting a timeout.

@elceef
Copy link
Owner

elceef commented Jan 29, 2024

Although I wasn't able to reproduce this error with that particular domain name, I agree this might be "fixed" with setting a longer timeout in the web driver. I will figure out a way to make it configurable - probably with environment variables.

@olifre
Copy link
Contributor Author

olifre commented Jan 29, 2024

Thanks! In fact, I also can not reproduce with that domain "now", it seems to be time-dependent — I likely hit a period of high load when running my tests. So having this configurable (environment variables is fine of course) for "flaky servers" seems like a good "solution".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants
@olifre @elceef and others