Use centralized version qualifier (#16995) #17005
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To avoid manual invocations specifying the version qualifier for prereleases in this commit we leverage a centralized version of truth for the version qualifier. We also honor the `DRA_BRANCH` BK var for the generated step names (the functionality was already there, it's just a cosmetic improvement).
|
💚 Build Succeeded
cc @dliappis |
|
closing this forward port due to #16995 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forward port PR #16995 to main branch, original message:
Release notes
[rn:skip]
What does this PR do?
To avoid manual invocations specifying the version qualifier for prereleases in this commit we leverage a centralized version of truth for the version qualifier.
We also honor the
DRA_BRANCHBK var for the generated step names (the functionality was already there, it's just a cosmetic improvement).Why is it important/What is the impact to the user?
Removes the need to specify VERSION_QUALIFIER when building DRA (staging) artifacts entirely.
How to test this PR locally
Can only be tested in BK. Links to be provided:
NOTE This is raised against 9.0 because it's the immediate need, and should be forward ported to
main, as well as backported to all 8.x branches.