Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport PR #16538 to 8.x: add http.* deprecation log #16582

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

github-actions[bot]
Copy link
Contributor

Backport PR #16538 to 8.x branch, original message:


This PR updates settings.rb and java Setting class, hence, needs to merge to main and backports to 8.x

Release notes

Add deprecation logs for http.host, http.port, http.enabled and http.environment

What does this PR do?

  • refactor deprecated alias to support obsoleted version to provide consistent deprecation warning
  • add deprecation log for http.* config

Why is it important/What is the impact to the user?

This commit gives users a clear message that http.* will be removed in next major.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files (and/or docker env variables)
  • I have added tests that prove my fix is effective or that my feature works

Author's Checklist

  • [ ]

How to test this PR locally

http.port: 9600
http.enabled: false
xpack.geoip.download.endpoint: ""
  • run logstash with the above logstash.yml
  • logstash-deprecation.log should say http.* will be removed in version 9 and xpack.geoip.download.endpoint will be removed in a future release

Related issues

Use cases

Screenshots

Logs

- refactor deprecated alias to support obsoleted version
- add deprecation log for http.* config

(cherry picked from commit 3f0ad12)
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

@kaisecheng kaisecheng merged commit 7e1877c into 8.x Oct 17, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants