Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logstash - Plugins - SSL Settings Standardization - Standardize Elasticsearch OUTPUT settings #14924

Closed
Tracked by #14905
edmocosta opened this issue Feb 28, 2023 · 0 comments · Fixed by logstash-plugins/logstash-output-elasticsearch#1118

Comments

@edmocosta
Copy link
Contributor

edmocosta commented Feb 28, 2023

This issue should make the plugin SSL settings consistent with the naming convention defined in the meta issue. Missing settings already supported by the plugin's HTTP/TCP client, which only requires small coding changes on the plugin source, should also be added through this issue.

Add and deprecate options to comply with the naming convention

  • ssl -> ssl_enabled
  • cacert -> ssl_certificate_authorities
  • keystore -> ssl_keystore_path
  • keystore_password -> ssl_keystore_password
  • truststore -> ssl_truststore_path
  • truststore_password -> ssl_truststore_password
  • ca_trusted_fingerprint (specific for ES plugins)

Add ssl_verification_mode functionality and mark ssl_certificate_verification as deprecated

  • Make it backward compatible

Check current functionality vs convention

  • ssl_supported_protocols

Add common settings validations

  • Not allow mixing the same deprecated and new setting on the same plugin configuration, e.g. ssl and ssl_enabled

Add missing settings/functionality that fits into the phase 1 description, and move non-phase 1-2 to the phase 3 issue (to be created if doesn't exist)

  • ssl_certificate
  • ssl_cipher_suites
  • ssl_handshake_timeout
  • ssl_key
  • ssl_key_passphrase
  • ssl_keystore_type
  • ssl_truststore_type
  • ssl_keystore_key_password
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant