Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the usage of pleaserun to configure the services script #12439

Closed
andsel opened this issue Nov 12, 2020 · 2 comments · Fixed by #12415
Closed

Remove the usage of pleaserun to configure the services script #12439

andsel opened this issue Nov 12, 2020 · 2 comments · Fixed by #12415
Assignees
@roaksoax
Labels
packaging

Comments

@andsel
Copy link
Contributor

andsel commented Nov 12, 2020 •
edited
Loading

Logstash uses Pleaserun to generate startup scripts and service definitions for various service managers like sysv, systemd, upstart etc.

Pleaserun is unmaintained and sometimes generate scripts that's malformed for certain distributions, see #12453 and jordansissel/pleaserun#146 for more details.

For these reason we should use another solution to generate the services scripts (in deb and rpm distributions)
@roaksoax
Copy link
Contributor

@andsel can you please file a different issue for the 'TimeoutStopSec=infinity' ? AS the removal of pleaserun (already in progress) won't address the other issue.

@roaksoax roaksoax mentioned this issue Nov 18, 2020
Merged
5 tasks
@roaksoax roaksoax self-assigned this Nov 18, 2020
@andsel
Copy link
Contributor Author

andsel commented Nov 19, 2020

Created issue #12453 to handle the fix on TimeoutStopSec

roaksoax added a commit to roaksoax/logstash that referenced this issue Nov 19, 2020
@roaksoax
Remove pleaserun (via bin/system-install) usage
0b23b7f 
This change removes the usage of 'pleaserun', which
was leveraged create the init.d scripts or systemd units.

Now, we ship init.d scripts and systemd units to make
the maintenance easier and following the lead of the
other Elastic projects.

Fixes: elastic#10519, Fixes: elastic#12439
roaksoax added a commit to roaksoax/logstash that referenced this issue Nov 30, 2020
@roaksoax
Remove pleaserun (via bin/system-install) usage
0d7e69e 
This change removes the usage of 'pleaserun', which
was leveraged create the init.d scripts or systemd units.

Now, we ship init.d scripts and systemd units to make
the maintenance easier and following the lead of the
other Elastic projects.

Fixes: elastic#10519, Fixes: elastic#12439
@roaksoax roaksoax mentioned this issue Nov 30, 2020
Open
5 tasks
roaksoax added a commit to roaksoax/logstash that referenced this issue Feb 10, 2022
@roaksoax
Remove pleaserun (via bin/system-install) usage
6aa13bb 
This change removes the usage of 'pleaserun', which
was leveraged create the init.d scripts or systemd units.

Now, we ship init.d scripts and systemd units to make
the maintenance easier and following the lead of the
other Elastic projects.

Fixes: elastic#10519, Fixes: elastic#12439
roaksoax added a commit that referenced this issue Mar 4, 2022
@roaksoax
Remove pleaserun (via bin/system-install) usage
f42ab41 
This change removes the usage of 'pleaserun', which
was leveraged create the init.d scripts or systemd units.

Now, we ship init.d scripts and systemd units to make
the maintenance easier and following the lead of the
other Elastic projects.

Fixes: #10519, Fixes: #12439
@roaksoax roaksoax mentioned this issue Mar 4, 2022
Closed
5 tasks
roaksoax added a commit that referenced this issue Mar 10, 2022
@roaksoax
Remove pleaserun (via bin/system-install) usage (#12415)
38fbe5a 
This change removes the usage of 'pleaserun', which
was leveraged create the init.d scripts or systemd units.

Now, we ship init.d scripts and systemd units to make
the maintenance easier and following the lead of the
other Elastic projects.

Fixes: #10519, Fixes: #12439, Fixes: #8253
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@roaksoax roaksoax

Labels
packaging
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove bin/system-install (pleaserun) usage roaksoax/logstash
2 participants
@andsel @roaksoax