Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Prometheus]: Field limit is too low #11466

Open
flash1293 opened this issue Oct 18, 2024 · 2 comments
Open

[Prometheus]: Field limit is too low #11466

flash1293 opened this issue Oct 18, 2024 · 2 comments
Labels
Integration:prometheus Prometheus needs:triage Team:Obs-InfraObs Label for the Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations]

Comments

@flash1293
Copy link
Contributor

Integration Name

Prometheus [prometheus]

Dataset Name

prometheus.collector

Integration Version

2.10.0

Agent Version

Agent Output Type

elasticsearch

Elasticsearch Version

8.15

OS Version and Architecture

Software/API Version

No response

Error Message

No response

Event Original

No response

What did you do?

The prometheus integration is used to collect arbitrary metrics. Because of this, it's easily possible for the number of fields in the index to grow a lot.

The current default is to index the first 1000 fields, then ignore everything else and not map it.

This limit should be raised to 10000 to make sure larger amounts of metrics are searchable properly

What did you see?

What did you expect to see?

Anything else?

No response

@flash1293 flash1293 added needs:triage Team:Obs-InfraObs Label for the Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] labels Oct 18, 2024
@flash1293 flash1293 changed the title [Integration Name]: Brief description of the issue [Prometheus]: Field limit is too low Oct 18, 2024
@lalit-satapathy
Copy link
Collaborator

Hi @flash1293,

Thanks for the issue. Definitely Prometheus package, packages using prometheus input is a potential candidate. We can also check other packages with usage of dynamic mappings.

Also, considering that index.mapping.total_fields.ignore_dynamic_beyond_limit is already set to true, is the impact somewhat less?

@flash1293
Copy link
Contributor Author

Also, considering that index.mapping.total_fields.ignore_dynamic_beyond_limit is already set to true, is the impact somewhat less?

@lalit-satapathy yes, the docs won't be dropped, but random metrics can end up being ignored which means they are essentially lost to the user.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Integration:prometheus Prometheus needs:triage Team:Obs-InfraObs Label for the Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations]
Projects
None yet
Development

No branches or pull requests

3 participants