[Azure monitor] Metric values are not mapped to the correct metric definition

[MichaelKatsoulis]

In Azure monitor metricset, after the metric values are collected from Azure api, the metricdefinition for which the values got fetched, is trying to be matched against the metric definitions stored in a in memory store.

beats/x-pack/metricbeat/module/azure/client.go

Line 269 in 0b475be

if matchMetrics(currentMetric, metric) {

For the matching process, Aggregations, Names , ResourceId and prevMet.TimeGrain is compared.

beats/x-pack/metricbeat/module/azure/client_utils.go

Line 94 in 04eac62

if prevMet.Namespace == met.Namespace && reflect.DeepEqual(prevMet.Names, met.Names) && prevMet.ResourceId == met.ResourceId &&

But there are cases that the metric definitions have all these fields the same but differ in Dimensions field.
That leads to the following:

• Metric values which have certain dimensions are added to a metric definition that was requesting different dimensions.
  

  beats/x-pack/metricbeat/module/azure/client.go

  Line 272 in 0b475be

  client.ResourceConfigurations.Metrics[i].Values = current

• When the metrics are then mapped to events to be published in ES, the dimensions of the metric definition is checked against the dimension of the metric values. If they do not match, then the value added is an empty string which results to a value empty in ES in the respectful dimension field.
  

  beats/x-pack/metricbeat/module/azure/azure.go

  Line 139 in 0b475be

  if err := mapToEvents(metricValues, m.Client, report); err != nil {

  
  

  beats/x-pack/metricbeat/module/azure/data.go

  Line 151 in 0b475be

  _, _ = dimensions.Put(dim.Name, getDimensionValue(dim.Name, value.dimensions))

  
  

  beats/x-pack/metricbeat/module/azure/data.go

  Line 411 in 0b475be

  func getDimensionValue(dimension string, dimensions []Dimension) string {

[elasticmachine]

Pinging @elastic/obs-ds-hosted-services (Team:obs-ds-hosted-services)